Update API URLs in doc link service #215084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcawl
added
Team:Docs
release_note:skip
Contributor
|
Pinging @elastic/kibana-docs (Team:Docs) |
sabarasaba
reviewed
Mar 20, 2025
Member
sabarasaba
left a comment
sabarasaba
left a comment
There was a problem hiding this comment.
I left one small comment, let me know!
.../index_management/__jest__/client_integration/index_details_page/index_details_page.test.tsx
Outdated
Show resolved
Hide resolved
Contributor
Yeah, I agree this is not well suited to large scale changes. Kibana uses snapshots in UI tests quite heavily and they do provide some level of assurance that we'll be getting the right URL in the UI and I don't see that practice going away soon... at least having the path reflected in tests might not be the worst idea? Otherwise we should fully stub out the URLs (there are ways to do this too...). I totally see how this kind of refactor is made painful though! OTOH we don't expect these URLs to change in this large scale fashion often so I'd like to make sure any change we do/do not make has that trade off in mind. Let me take this to the Core team! |
…t_integration/index_details_page/index_details_page.test.tsx Co-authored-by: Ignacio Rivas <[email protected]>
9 tasks
Contributor
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
History
|
SoniaSanzV
approved these changes
Apr 16, 2025
Contributor
SoniaSanzV
left a comment
SoniaSanzV
left a comment
There was a problem hiding this comment.
Kibana management changes lgtm :)
Contributor
|
Starting backport for target branches: 8.18, 8.x, 9.0 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 16, 2025
Co-authored-by: Ignacio Rivas <[email protected]> Co-authored-by: Jean-Louis Leysens <[email protected]> (cherry picked from commit b969cc9)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
lcawl
added a commit
to lcawl/kibana
that referenced
this pull request
Apr 16, 2025
Co-authored-by: Ignacio Rivas <[email protected]> Co-authored-by: Jean-Louis Leysens <[email protected]> (cherry picked from commit b969cc9)
lcawl
added a commit
to lcawl/kibana
that referenced
this pull request
Apr 16, 2025
Co-authored-by: Ignacio Rivas <[email protected]> Co-authored-by: Jean-Louis Leysens <[email protected]> (cherry picked from commit b969cc9)
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
Apr 17, 2025
Co-authored-by: Ignacio Rivas <[email protected]> Co-authored-by: Jean-Louis Leysens <[email protected]>
kibanamachine
added
the
backport missing
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
1 similar comment
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
lcawl
added a commit
that referenced
this pull request
Apr 22, 2025
# Backport This will backport the following commits from `main` to `9.0`: - [Update API URLs in doc link service (#215084)](#215084) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Lisa Cawley","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-04-16T14:18:47Z","message":"Update API URLs in doc link service (#215084)\n\n\nCo-authored-by: Ignacio Rivas <[email protected]>\nCo-authored-by: Jean-Louis Leysens <[email protected]>","sha":"b969cc9e3dac819c0498ab2e68e27a74c4b91a88","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","release_note:skip","docs","backport:version","v9.1.0","v8.19.0","v8.18.1","v9.0.1"],"title":"Update API URLs in doc link service","number":215084,"url":"https://github.com/elastic/kibana/pull/215084","mergeCommit":{"message":"Update API URLs in doc link service (#215084)\n\n\nCo-authored-by: Ignacio Rivas <[email protected]>\nCo-authored-by: Jean-Louis Leysens <[email protected]>","sha":"b969cc9e3dac819c0498ab2e68e27a74c4b91a88"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.18","9.0"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/215084","number":215084,"mergeCommit":{"message":"Update API URLs in doc link service (#215084)\n\n\nCo-authored-by: Ignacio Rivas <[email protected]>\nCo-authored-by: Jean-Louis Leysens <[email protected]>","sha":"b969cc9e3dac819c0498ab2e68e27a74c4b91a88"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: Lisa Cawley <[email protected]>
lcawl
added a commit
that referenced
this pull request
Apr 22, 2025
# Backport This will backport the following commits from `main` to `8.18`: - [Update API URLs in doc link service (#215084)](#215084) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Lisa Cawley","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-04-16T14:18:47Z","message":"Update API URLs in doc link service (#215084)\n\n\nCo-authored-by: Ignacio Rivas <[email protected]>\nCo-authored-by: Jean-Louis Leysens <[email protected]>","sha":"b969cc9e3dac819c0498ab2e68e27a74c4b91a88","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","release_note:skip","docs","backport:version","v9.1.0","v8.19.0","v8.18.1","v9.0.1"],"title":"Update API URLs in doc link service","number":215084,"url":"https://github.com/elastic/kibana/pull/215084","mergeCommit":{"message":"Update API URLs in doc link service (#215084)\n\n\nCo-authored-by: Ignacio Rivas <[email protected]>\nCo-authored-by: Jean-Louis Leysens <[email protected]>","sha":"b969cc9e3dac819c0498ab2e68e27a74c4b91a88"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.18"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/215084","number":215084,"mergeCommit":{"message":"Update API URLs in doc link service (#215084)\n\n\nCo-authored-by: Ignacio Rivas <[email protected]>\nCo-authored-by: Jean-Louis Leysens <[email protected]>","sha":"b969cc9e3dac819c0498ab2e68e27a74c4b91a88"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/218457","number":218457,"state":"OPEN"}]}] BACKPORT-->
lcawl
added a commit
that referenced
this pull request
Apr 22, 2025
# Backport This will backport the following commits from `main` to `8.x`: - [Update API URLs in doc link service (#215084)](#215084) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Lisa Cawley","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-04-16T14:18:47Z","message":"Update API URLs in doc link service (#215084)\n\n\nCo-authored-by: Ignacio Rivas <[email protected]>\nCo-authored-by: Jean-Louis Leysens <[email protected]>","sha":"b969cc9e3dac819c0498ab2e68e27a74c4b91a88","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","release_note:skip","docs","backport:version","v9.1.0","v8.19.0","v8.18.1","v9.0.1"],"title":"Update API URLs in doc link service","number":215084,"url":"https://github.com/elastic/kibana/pull/215084","mergeCommit":{"message":"Update API URLs in doc link service (#215084)\n\n\nCo-authored-by: Ignacio Rivas <[email protected]>\nCo-authored-by: Jean-Louis Leysens <[email protected]>","sha":"b969cc9e3dac819c0498ab2e68e27a74c4b91a88"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.18"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/215084","number":215084,"mergeCommit":{"message":"Update API URLs in doc link service (#215084)\n\n\nCo-authored-by: Ignacio Rivas <[email protected]>\nCo-authored-by: Jean-Louis Leysens <[email protected]>","sha":"b969cc9e3dac819c0498ab2e68e27a74c4b91a88"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/218457","number":218457,"state":"OPEN"}]}] BACKPORT-->
kibanamachine
removed
the
backport missing
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
May 29, 2025
Co-authored-by: Ignacio Rivas <[email protected]> Co-authored-by: Jean-Louis Leysens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Relates to #217722
This PR:
upgradeAssistant.unfreezeApitarget and removes theunfreezeIndexkeyword from the service since the API was removed per Remove unfreeze REST endpoint elasticsearch#119227Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesIdentify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.